-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vae tiling improvements: encoding support and adaptative overlap #484
base: master
Are you sure you want to change the base?
Conversation
9edc59f
to
af0491b
Compare
6f49af0
to
6f96903
Compare
Nice! It would also be interesting to see larger tile sizes. Depending on VAE, larger tiles would still fit into the memory budget and would speed things up. |
5495c93
to
e9a8d17
Compare
e9a8d17
to
d103632
Compare
I am not familiar with AI programming, and this is a machine translation, so please ignore me if I say something strange. The However, the brightness issue (issue #588) seems to remain. |
I'm sorry, I don't quite understand what you mean.
You mean this PR doesn't fix it for you? If so this is strange, I can't reproduce the issue with this PR...
As you can see the image made with the master branch is much brighter than the one with this PR. |
sd_tiling()
function, specifying if the output tile is scaled up (for decoding) or if the input is (encoding).With these changes, vae encoding can now be tiled, and a small (unreported?) issue with the upscaler (or tae) over-brightening some parts of the image is now fixed. This could also be a step toward tiled diffusion support.
Fixes #588 and #564