Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helpText to LicenseDropdown component #4739

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Sep 17, 2024

Summary

Description of the change(s) you made

This pull request addresses the issue of the overlapping "About Licenses" dropdown button with the text Cannot edit for public channel resources by moving the helpText to the LicenseDropdown component as a new parameter.

Screenshots (if applicable)

Before After
before after

Reviewer guidance

How can a reviewer test these changes?

  1. Open a channel and import a resource from another channel
  2. Open the Edit source modal for that resource

References

Fixes #4736


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - just one request to add a comment for the hardcoded px value

@@ -277,4 +284,13 @@
}
}

.help {
position: relative;
top: -25px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put a comment explaining why this is hardcoded like this? It LGTM but since it is a particular case it can be helpful to leave a note about what this is doing on the page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point, I'll add that in.

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LianaHarris360 I tested and tried a couple times to be sure that when I have nodes I've copied from a published & public channel and paste them into a new channel, I don't see the text beneath the inputs for the 4 disabled inputs.

I confirmed the channel I copied from to be public by going to the Administration page and seeing it had the green dot.

Am I maybe not testing out the correct situation?

@LianaHarris360
Copy link
Member Author

Hmm, I think maybe you're on the edit details page, the help text does not show on there. But now I'm wondering why the help text displays within the edit source modal but not when trying to edit the source from the edit details page.

editSource.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - Edit source - The 'About licenses' link is overlapping the text below it
2 participants