Skip to content

Commit

Permalink
Merge pull request #666 from MisRob/lighter-img-placeholder
Browse files Browse the repository at this point in the history
Update KImg's placeholder and letterbox area background color
  • Loading branch information
MisRob authored Jun 19, 2024
2 parents 4ae7503 + 1f09a8c commit 0cbdf57
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,17 @@ Changelog is rather internal in nature. See release notes for the public overvie

## Upcoming version 5.x.x (`develop` branch)

- [#666]
- **Description:** Update `KImg`'s placeholder and letterbox area background color to a lighter shade of grey, `v_50`.
- **Products impact:** UI appearance update
- **Addresses:** -
- **Components:** `KImg`, `KCard`
- **Breaking:** no
- **Impacts a11y:** no
- **Guidance:** -

[#666]: https://github.com/learningequality/kolibri-design-system/pull/666

- [#652]
- **Description:** KTextTruncator drops support for Internet Explorer 11
- **Products impact:** browser support update
Expand Down
4 changes: 2 additions & 2 deletions lib/KImg/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
* (3) a progressive loading experience as the colored background
* is displayed while an image is loading.
*
* Its default value is `$themePalette.grey.v_200`.
* Its default value is `$themePalette.grey.v_50`.
*/
backgroundColor: {
type: String,
Expand Down Expand Up @@ -174,7 +174,7 @@
baseStyles() {
const backgroundColor = this.backgroundColor
? this.backgroundColor
: this.$themePalette.grey.v_200;
: this.$themePalette.grey.v_50;
const borderRadius = this.borderRadius ? this.borderRadius : 0;
return {
Expand Down

0 comments on commit 0cbdf57

Please sign in to comment.