Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Matroid/Circuit): fundamental circuits and extensionality #21145

Closed
wants to merge 5 commits into from

Conversation

apnelson1
Copy link
Collaborator

We define the fundamental circuit in a matroid for a set I and an element e, then use it to show that dependent sets all contain circuits, and a circuit-based extensionality lemma.


Open in Gitpod

Copy link

github-actions bot commented Jan 27, 2025

PR summary db9c0ecac7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Base.fundCircuit_circuit
+ Circuit.eq_fundCircuit_of_subset
+ Circuit.eq_of_superset_circuit
+ Dep.exists_circuit_subset
+ Indep.fundCircuit_circuit
+ Indep.mem_fundCircuit_iff
+ dep_iff_superset_circuit
+ dep_iff_superset_circuit'
+ ext_circuit
+ ext_circuit_not_indep
+ ext_iff_circuit
+ fundCircuit
+ fundCircuit_eq_of_mem
+ fundCircuit_eq_of_mem'
+ fundCircuit_eq_sInter
+ fundCircuit_subset_ground
+ fundCircuit_subset_insert
+ indep_iff_forall_subset_not_circuit
+ indep_iff_forall_subset_not_circuit'
+ mem_fundCircuit

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Jan 27, 2025
@grunweg grunweg changed the title feat(Data/Matroid/Circuit): Fundamental circuits and extensionality feat(Data/Matroid/Circuit): fundamental circuits and extensionality Jan 27, 2025
Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice!

Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
@b-mehta b-mehta added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 28, 2025
@apnelson1
Copy link
Collaborator Author

Looks really nice!

Thanks for the very helpful review!

@apnelson1 apnelson1 removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 28, 2025
Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things I noticed on my final pass. Thank you!

bors d+

Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
Mathlib/Data/Matroid/Circuit.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 28, 2025

✌️ apnelson1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@apnelson1
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jan 28, 2025
…21145)

We define the fundamental circuit in a matroid for a set `I` and an element `e`, then use it to show that dependent sets all contain circuits, and a circuit-based extensionality lemma.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 28, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Matroid/Circuit): fundamental circuits and extensionality [Merged by Bors] - feat(Data/Matroid/Circuit): fundamental circuits and extensionality Jan 28, 2025
@mathlib-bors mathlib-bors bot closed this Jan 28, 2025
@mathlib-bors mathlib-bors bot deleted the matroid_fund_circuit branch January 28, 2025 04:04
Julian added a commit that referenced this pull request Jan 28, 2025
* origin/master: (294 commits)
  feat: equalizers and coequalizers in the category of ind-objects (#21139)
  doc: turn more links to Stacks into `@[stacks]` tags (#21135)
  feat(Asymptotics): prove `IsLittleOTVS.add` (#20578)
  feat(Algebra/Polynomial): `Polynomial.aeval` for product algebras (#21062)
  chore: import Std in Mathlib.lean (#21126)
  feat(Data/Matroid/Circuit): fundamental circuits and extensionality  (#21145)
  feat(CategoryTheory/Endofunctor): prove the dual form of Lambek's Lemma on terminal coalgebra (#21140)
  feat(SetTheory/Game/PGame): rewrite left moves of `-x` as right moves of `x` under binders (#21109)
  feat(RingTheory/Localization/Pi): localization of a finite direct product is a product of localizations (#19042)
  doc: fixed notation error in customizing category composition (#21132)
  feat(Matrix): more lemmas for `PEquiv.toMatrix` (#21143)
  chore(SupIndep): speedup the `Decidable` instance (#21114)
  fix(CI): use `Elab.async=false` for late importers workflow (#21147)
  feat(Topology/Algebra/Indicator): indicator of a clopen is continuous (#20687)
  feat(Data/Matroid/Rank/Cardinal): Cardinality-valued rank function (#20921)
  feat(Algebra): `Pi.single_induction` (#21141)
  chore(BigOperators/Fin): golf a proof (#21131)
  feat: generalize tangent cone lemmas to TVS (#20859)
  feat(CategoryTheory): `Comma.snd L R` is final if `R` is final and domains are filtered (#21136)
  refactor: unapply matrix lemmas (#21091)
  chore(Algebra/Category): `erw` -> `rw` (#21130)
  feat(CategoryTheory): filteredness of Comma catgories given finality of one of the functors (#21128)
  feat(Algebra/Category): `ConcreteCategory` instance for `ModuleCat` (#21125)
  feat: PSum of finite sorts is finite (#20285)
  feat: inequality on the integral of a convex function of a RN derivative (#21093)
  feat: `(v +ᵥ s) -ᵥ (v +ᵥ t) = s -ᵥ t` (#21058)
  chore: rename the fact that `(∀ a < a₁, a ≤ a₂) ↔ a₁ ≤ a₂` in a dense order (#20317)
  feat: a `RelHom` preserves directedness (#20080)
  feat(Combinatorics/SimpleGraph): add definitions and theorems about the coloring of sum graphs (#18677)
  chore(Data/Matrix/PEquiv): clean up names (#21108)
  feat(Algebra/Category): `ConcreteCategory` instances for rings (#20815)
  feat: define Descriptive.Tree (#18763)
  chore(Data/Complex/Exponential): split trig functions to new file (#21075)
  feat(Logic/IsEmpty/Relator): empty on sides (#20319)
  feat(Algebra/Category): `ConcreteCategory` instance for `AlgebraCat` (#21121)
  feat(NumberTheory/LSeries): results involving partial sums of coefficients (part 1) (#20661)
  feat(RingTheory/LaurentSeries): add algebraEquiv (#21004)
  chore(SetTheory/Game/Impartial): golf two proofs (#21074)
  feat(CategoryTheory/Subpresheaf): preimage/image/range of subpresheaves (#21047)
  feat(RingTheory/IntegralClosure): `Algebra.IsIntegral` transfers via surjective homomorphisms (#21023)
  feat(`InformationTheory/Hamming`): Add AddGroup instances (#20994)
  feat(RingTheory/IntegralClosure): prove `Module.Finite R (adjoin R S)` for finite set `S` of integral elements (#20970)
  feat(RingTheory/Artinian): `IsUnit a` iff `a ∈ R⁰` for an artinian ring `R` (#21084)
  feat: separating set in the category of ind-objects (#21082)
  feat: derivWithin lemmas (#21092)
  chore(Fintype): golf a proof (#21113)
  chore: golf using `funext₂` (#21106)
  chore(Algebra/Group/Submonoid/Operations): move instances to new file (#21067)
  doc(Algebra/BigOperators/Fin): change 'product' to 'sum' in doc-string of additivised declarations (#21101)
  doc(ComputeDegree): typos (#21095)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants