Fix wrong search query in subject #2
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we use a standard port and try to search it for a string with mandatory port specification (function getHostWithPort()), the string will not be found. We need to either look for getUrl() in the subject or change the subject from `request()->getUrl()` to `request()->getScheme() . '://' . request()->getHostWithPort()` because the getUrl() function does not output the port if it is standard.
mychidarko
approved these changes
Mar 9, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (pls check at least one)
Description
If we use a standard port and try to search it for a string with mandatory port specification (function
getHostWithPort()), the string will not be found. We need to either look forgetUrl()in the subject or change the subject fromrequest()->getUrl()torequest()->getScheme() . '://' . request()->getHostWithPort()because thegetUrl()function does not output the port if it is standard.Does this PR introduce a breaking change? (check one)
Related Issue
#1