Support for private date (issue #61) #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requests-cache. Instead, `requests_cache` can be used directly.
… is always 0. Cause: `add_collection_items_from_xml()` gets the publishing year from the 'value' attribute of a 'yearpublished' element (using `xml_subelement_attr`), but in a collection, the publishing year is text content of 'yearpublished'. Soln: use `xml_subelement_text` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly, these commits are about supporting private information from the BGG API (issue #61). There are a few with other updates: a new XML utility function (
xml_attr) in the spirit of others, tests for loaders/collection.py and a bugfix foradd_collection_items_from_xml. It also includes a fix for issue #67 (which is also accomplished by pull #68), but that was only so the tests wouldn't get stopped by it.