Add more precise interface handleTimeoutMicroseconds #546
Conversation
horten the name Co-authored-by: Tim Perkins <[email protected]>
shorten function name Co-authored-by: Tim Perkins <[email protected]>
There was a problem hiding this comment.
Are you interested in adding lcm_handle_timeout_us to the Python module? If so, you can reference the existing bindings for lcm_handle_timeout via git grep -n handle_timeout lcm-python/. There's also some tests for those that you can reference with git grep -n handle_timeout test/python/.
If not, that's fine too; I'll just pop an issue to track that as future work.
|
|
||
| // Invalid timeout specification should result in an error. | ||
| EXPECT_GT(0, lcm.handleTimeoutUs(-1)); | ||
|
|
There was a problem hiding this comment.
Underneath this line, there is the following test for handleTimeout:
// Subscribe to and publish on a channel. Expect that the message gets
// handled with an ample timeout.
bool msg_handled = false;
lcm.subscribeFunction("channel", MemqTimeoutHandler, &msg_handled);
lcm.publish("channel", "", 0);
EXPECT_LT(0, lcm.handleTimeout(10000));
EXPECT_TRUE(msg_handled);Can you duplicate these assertions for handleTimeoutUs as well? It would be good to have as many tests for the new method as for the old.
| * New in LCM 1.1.0. | ||
| * |
There was a problem hiding this comment.
This method does not exist in LCM 1.1.0
| * New in LCM 1.1.0. | |
| * |
| * returns immediately. Values less than 0 are not allowed. | ||
| * | ||
| * @return >0 if a message was handled, 0 if the function timed out, and <0 if | ||
| * an error occured. |
There was a problem hiding this comment.
Typo
| * an error occured. | |
| * an error occurred. |
It also occurs in the lcm_handle_timeout docstring, in case you feel like fixing it there too.
| * New in LCM 1.1.0. | ||
| * |
There was a problem hiding this comment.
This method does not exist in LCM 1.1.0
| * New in LCM 1.1.0. | |
| * |
Just add a new interface handleTimeoutMicroseconds