Major Refactor WIP #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leopere
added
type: improvement
|
Depends on updates to this issue referenced #36 (comment) |
|
this needs to be squashed something fierce.
|
|
The refactor needs documentation updates and a twice over to ensure that there are no dangling references and a final squash & rebase. |
|
I've read through all of the documentation to verify things are copacetic, and I feel that things are relatively concise and functional no dangling URL or tag references I've set up the following repositories to build the docker files within this repository. There will need to be a huge overhaul of documentation but that's out of scope for this refactor. |
Moved data dir and removed traefik label Moved readme for testnet compose Adding RUN_MODEs regtest and testnet Adding advance_blocks.sh into all lbrycrd containers Adding advance cmd and moved Dockerfile to appropriate dir Cleanup and moved Dockerfiles Moved lbrycrd Dockerfiles to appropriate subdirectories and removed. More moving and deletions Adding catchall output Updated default runmode in example Removed incomplete container directory This should not be in a production branch at this point now that we have stable containers published. Removed incomplete container for now Deleted compile directory and README.md Cleaning up chainquery Deleting placeholders Updated start.sh Removing superfluous .dockerignores & more Adjusted start.sh source path Updated ignores Updated readme in prep for build tags and ship armhf-prod dir start.sh's should be recycled when possible. No sense in code duplication lets try and aim for unification. Docker prefers WORKDIR over cd docker prefers WORKDIR over cd
Replaced build with image docker-compose.yml-prod-example Adjusted paths in volumes Removed a few more things healthcheck.sh which can be added later when completed. renamed the Dockerfile to Dockerfile-x86_64-production Updated image tag and added RUN_MODE Updated image and added RUN_MODE updated tag Updated tag
Renamed to fit with new nomenclature Removed directory and renamed/moved Dockerfile Updated COPY path Moved docker-compose.yml for Lbrynet Cleaned up comments a bit Important notice to users in new comment Updated compose example for image instead of build updated paths Added a step for chainquery-bootstrap setup Moved and updated lbrycrd's env_file Created lbrynet env_file Moved and updated chainquery's env_file Moved and updated lbrynet's compose file More Cleanup Added TODO's for checkmount.sh Renamed compiler Renamed production container Final rename fixup fixup Updated README refs Just readability improvements Packing directories with the repo Git won't track empty directories but if you take the path of running these containers locally from within this repo you should have this directory. Updated image refs to final production locations
Closes #49
|
Closes #49 |
|
Closes #36 |
This was referenced Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor PR is a work in progress, @EnigmaCurry, and I are cleaning up this repository now that we've committed ourselves to just doing all of the container orchestration from within this repository rather than getting in the way of others within the LBRY Inc organization.