Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option tapeColor #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kontur
Copy link

@kontur kontur commented May 13, 2013

I added a $.typer.option.tapeColor option that let's developers overwrite the standard behviour of overwriting the text with a "color tape" the same color as the initial font color and instead a custom color can be provided.

This is a potential fix for issue #3

@kontur kontur mentioned this pull request May 13, 2013
@@ -224,7 +225,7 @@ String.prototype.rightChars = function(n){
$e.data('oldRight', currentText.rightChars(j - 1));
$e.data('leftStop', i);
$e.data('rightStop', currentText.length - j);
$e.data('primaryColor', $e.css('color'));
$e.data('primaryColor', $.typer.options.tapeColor === 'auto' ? $e.data('primaryColor') : $.typer.options.tapeColor);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the second condition be $e.css('color') as in the original implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants