-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update pre commit hook to lint only staged files #7326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CodexRaunak
wants to merge
8
commits into
layer5io:master
Choose a base branch
from
CodexRaunak:update-pre-commit-hook
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
91c84e4
Only lint staging files using lint-staged
CodexRaunak 2ae87e5
Modify the precommit hook to use lint staged
CodexRaunak c58a322
Modify prepare script to never fail and remove deprecated install
CodexRaunak c427d1f
Merge branch 'master' into update-pre-commit-hook
CodexRaunak 4bd11dc
Merge branch 'master' into update-pre-commit-hook
saurabhraghuvanshii b625e2a
Merge branch 'master' into update-pre-commit-hook
CodexRaunak c18ac0b
Merge branch 'master' into update-pre-commit-hook
Rajesh-Nagarajan-11 3bf66f7
Merge branch 'master' into update-pre-commit-hook
Rajesh-Nagarajan-11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| npm run lint | ||
| npx lint-staged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| module.exports = { | ||
| // Lint & Prettify TS and JS files - only the staged files | ||
| "**/*.(ts|tsx|js|jsx)": (filenames) => [ | ||
| `cross-env NODE_ENV=test npx eslint --fix --max-warnings=0 ${filenames.map((f) => `'${f.replace(/'/g, "'\\''")}'`).join(" ")}`, | ||
| `npx prettier --write ${filenames.map((f) => `'${f.replace(/'/g, "'\\''")}'`).join(" ")}`, | ||
| ], | ||
|
|
||
| // Prettify only Markdown and JSON files | ||
| "**/*.(md|json)": (filenames) => | ||
| `npx prettier --write ${filenames.map((f) => `'${f.replace(/'/g, "'\\''")}'`).join(" ")}`, | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodexRaunak I think this file is over-engineered because some lint-staged already:
And I have question why you're using
npxwhy notnpm run lintwhich already point toeslint --fix