pricing list reuseable workflow call #5919
Conversation
|
@SAHU-01 Please add it as an agenda item to the meeting minutes. |
|
🚀 Preview for commit 0e0d317 at: https://66f1456cbbdedfda387ac2bb--layer5.netlify.app |
.github/workflows/pricing-list.yml
Outdated
| @@ -0,0 +1,21 @@ | |||
| name: Trigger Pricing List Workflow | |||
There was a problem hiding this comment.
Let's refer to this as a features list, please (in the filename, too).
| const summary = data | ||
| .filter( | ||
| (item) => | ||
| item.entire_row["Subscription Tier"] === tierName && |
There was a problem hiding this comment.
Please confirm that there is a comment in the spreadsheet on this cell letting people know where to update feature list workflows if they change the column name.
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
|
🚀 Preview for commit f0214ad at: https://672dc88c826e4519b1aede45--layer5.netlify.app |
Signed-off-by: Ankita Sahu <[email protected]>
|
🚀 Preview for commit 468751f at: https://672dd2fe5df160246cdc924c--layer5.netlify.app |
Signed-off-by: Ankita Sahu <[email protected]>
|
🚀 Preview for commit 06bf498 at: https://6736c37c2072aeffdd838bfe--layer5.netlify.app |
|
did you incorporated coming soon? @SAHU-01 |
|
@jerensl workflow looks good? |
Yes @sudhanshutech the logic is there, in the json file if you add |
Signed-off-by: Ankita Sahu <[email protected]>
|
🚀 Preview for commit 661ca03 at: https://6736e730171fe5103fd8a52d--layer5.netlify.app |
.github/workflows/feature-list.yml
Outdated
| commit_options: "--signoff" | ||
| commit_user_name: l5io | ||
| commit_user_email: [email protected] | ||
| commit_author: ${{ github.actor }} <${{ github.actor }}@users.noreply.github.com> |
There was a problem hiding this comment.
This github.actor is fragile, sometimes it willl refer to the person who merge this PR
There was a problem hiding this comment.
What possible fix would you suggest for this one?
There was a problem hiding this comment.
@jerensl any reference or example?
There was a problem hiding this comment.
There was a problem hiding this comment.
thanks jeren, @SAHU-01 lets finish this.
There was a problem hiding this comment.
Done, @sudhanshutech !
There was a problem hiding this comment.
lets give a final review on the call by everyone then will merge.
Signed-off-by: Ankita Sahu <[email protected]>
|
🚀 Preview for commit 6af6a42 at: https://673763768b081eb3559ef928--layer5.netlify.app |
|
@SAHU-01 good to go now? |
|
🚀 Preview for commit 80e17d9 at: https://6738aedd05718262113b9d7a--layer5.netlify.app |
Yes @sudhanshutech, should I remove the dummy coming soon data? That was added for displaying the logic here . |
|
yes please remove so we can merge |
Signed-off-by: Ankita Sahu <[email protected]>
Sure, done. |
|
🚀 Preview for commit 6774d51 at: https://673aa3af057182913c3b9d6b--layer5.netlify.app |
Description
This PR adds a pricing list to layer5io and the data is populated by a workflow.
Notes for Reviewers
Signed commits