Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client config flag to explicitly signal Opus support #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

s3lph
Copy link

@s3lph s3lph commented Mar 15, 2022

Add client config flag to explicitly signal Opus support even when the Opus audio codec is not loaded.

This is useful if a client based on gumble doesn't actually process audio at all. By signalling Opus support anyway, this doesn't force everyone back to CELT if a gumble client is the only client not claiming Opus support. We can't be sure that the server admin has actually set opusthreshold = 0, so this is a pure-client way to prevent a CELT fallback.

@ghost
Copy link

ghost commented Mar 16, 2022

how about a dummy opus codec that registers itself but doesn't process the audio?

@s3lph
Copy link
Author

s3lph commented Mar 16, 2022

That is actually what I proposed initially as a solution for matterbridge (the project we want this for, see 42wim/matterbridge#1750 for the discussion), but @42wim (matterbridge maintainer) and I agree that we find the dummy codec solution to be a rather ugly workaround for something that's a simple boolean flag. We do have a working dummy codec implementation (42wim/matterbridge#1764), but would like to avoid using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant