close listener connection on TimedOut and BrokerPipe errors #3648

DXist · 2024-12-20T06:16:14Z

This PR handles TimedOut and BrokerPipe errors that could be returned by tcp layer:

EPIPE  The other end closed the socket unexpectedly or a read is
              executed on a shut down socket.

ETIMEDOUT
      The other end didn't acknowledge retransmitted data after
      some time.

In these cases it makes sense to close listener connection proactively.

paolobarbolini · 2024-12-21T15:56:28Z

sqlx-postgres/src/listener.rs

                    if (err.kind() == io::ErrorKind::ConnectionAborted
-                        || err.kind() == io::ErrorKind::UnexpectedEof) =>
+                        || err.kind() == io::ErrorKind::UnexpectedEof
+                        // see ERRORS section in tcp(7) man page (https://man7.org/linux/man-pages/man7/tcp.7.html)
+                        || err.kind() == io::ErrorKind::TimedOut
+                        || err.kind() == io::ErrorKind::BrokenPipe) =>


Using matches! may make this section a bit cleaner

Rewrote the expression using matches! macro.

close listener connection on TimedOut and BrokerPipe errors

3c0d561

paolobarbolini reviewed Dec 21, 2024

View reviewed changes

use matches macro to generate jump table instead of chain of conditions

7195078

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

close listener connection on TimedOut and BrokerPipe errors #3648

close listener connection on TimedOut and BrokerPipe errors #3648

DXist commented Dec 20, 2024

paolobarbolini Dec 21, 2024

DXist Dec 22, 2024

close listener connection on TimedOut and BrokerPipe errors #3648

Are you sure you want to change the base?

close listener connection on TimedOut and BrokerPipe errors #3648

Conversation

DXist commented Dec 20, 2024

paolobarbolini Dec 21, 2024

Choose a reason for hiding this comment

DXist Dec 22, 2024

Choose a reason for hiding this comment