Dont use EXPLAIN in nullability check for QuestDB
#3640
+11
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Dec 20, 2024
Comment on lines
490
to
494
| let parameter_statuses = &self.inner.stream.parameter_statuses; | ||
| let is_cockroachdb = parameter_statuses.contains_key("crdb_version"); | ||
| let is_materialize = parameter_statuses.contains_key("mz_version"); | ||
| let is_questdb = parameter_statuses.contains_key("questdb_version"); | ||
| if !is_cockroachdb && !is_materialize && !is_questdb { |
There was a problem hiding this comment.
Might as well lift this to an is_explain_available() method which would make this easier to find/update in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QuestDB has the same limitation as Materialize and CockroachDB when parsing
EXPLAINstatements.This PR applies the same fix as in #1386 and #2282.
This change makes the new 8.2.0 release of QuestDB and
sqlxminimally compatible.