-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add begin_with
methods to support database-specific transaction options
#3614
Open
bonsairobo
wants to merge
13
commits into
launchbadge:main
Choose a base branch
from
ForesightMiningSoftwareCorporation:duncan/begin-with
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add begin_with
methods to support database-specific transaction options
#3614
bonsairobo
wants to merge
13
commits into
launchbadge:main
from
ForesightMiningSoftwareCorporation:duncan/begin-with
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These updates are forced as soon as I build.
This patch completes the plumbing of an optional statement from these methods to `TransactionManager::begin` without any validation of the provided statement. There is a new `Error::InvalidSavePoint` which is triggered by any attempt to call `Connection::begin_with` when we are already inside of a transaction.
…nts are successful
bonsairobo
force-pushed
the
duncan/begin-with
branch
from
November 28, 2024 03:14
8bfcad6
to
2041cdf
Compare
bonsairobo
force-pushed
the
duncan/begin-with
branch
from
November 28, 2024 03:23
2041cdf
to
7ab05a6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
abonander
requested changes
Dec 2, 2024
This makes the new method a non-breaking change.
Move the wrapper directly into the test that uses it instead.
This comment was marked as outdated.
This comment was marked as outdated.
I'm having trouble running the MySQL tests locally. I keep ending up with this error:
Even after I remove the mysql container. |
@abonander All review comments have been addressed. Mind taking another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #481