Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/openqxd #1414
base: develop
Are you sure you want to change the base?
Feature/openqxd #1414
Changes from 136 commits
ed966db
71c1897
efc24b8
61b8a02
a40b032
0a69472
c29aa66
d3d4022
9e1b7ad
aec93e3
1f0e573
6271fac
ef1e5af
8550ed0
c9d0f6c
301378b
240d614
6202ac4
cf3a04a
16b7df0
12f22f4
d535512
f538e53
568d1cd
dc8c99f
ecc2177
8b1830d
f738510
ad8f689
189896e
37e6023
b0076de
2525a5b
9dce279
4ff5cce
b2d7446
fdf641c
ca66195
bc95079
e1bed36
5e60bc5
402cab6
ed234bd
bfe766f
b837622
23b1e0b
b577392
26918e6
d3fdc43
fe01653
34d388d
b6157c5
fdd1b62
be90f9d
736d2cd
3f131b0
92a8b50
088678e
271f828
00136bf
076cf0e
d9c4fff
a37c286
7c89362
5c21522
30ae3bd
7985910
5f57224
fd9975e
78465cf
9f52f30
61e4985
ef78041
18518f5
29da468
8ababe5
53d9a8c
4a9ba76
1cac7c0
96bb7ab
ed254d5
febf4fb
83ce801
0c9bcf0
2a91f8b
3a0012c
d929534
14baf0f
1f7fb9a
ac3d0d0
e7eaaa9
abdcbcc
732d760
25ed056
b69b67a
748693a
f663ec2
129c578
512e3e9
4d9b28a
236f869
cdd360e
025b0e3
dd0e4a5
86134fb
3ad9b06
36251b5
a0d8622
ec3e911
86ff1d5
b8bc138
1ce6b19
9e81a4c
9778011
8f4c7dc
608dec2
1c85393
3af70d1
0842ed0
ef57751
0020993
e622ce8
7085cc5
ad6787a
df1bd16
93c3f6a
8301dbf
200295d
59578cc
bab885c
dd29926
43a1b4f
23fefb1
848e6d9
02b8481
ae170fe
d56921e
886c90f
e6ce728
ba9ace1
1b1a55c
c2c8ef6
dd92262
20e59ba
d40d6e5
6c7bb9d
005aed9
ad1ab82
c1fec52
d356fa0
a80dd55
466d702
c79cb4a
6edc863
568dd37
3150761
0752a23
ca54f7e
9d9ace7
f63a507
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, whether QUDA has sufficient capability to create the clover term for OpenQ*D's use case or whether you have specific requirements that we are lacking? E.g., exponential clover or anisotropy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a
static_assert
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We extended the Topology struct with a cstar member to indicate how many spatial directions have C* boundaries. Maybe you want to have that as a option in the
QudaInvertParam
struct? However, we need this setting here, since it influences in the process grid topology.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgive my ignorance, but are the C* boundaries only relevant for fermions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we change the rank-topology based on how many C* directions we have. If there is a C* direction, we calculate the rank displacement in X-direction (
NX_displacement
) accordingly.topo->cstar=0
recovers legacy behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed gamma0 to gamma3 for tests in openQxD side. Let me know if there is an intended way to apply a gamma matrix other than gamm5 to a spinor field (I didn't find anything).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we've needed anything other in gamma5 in the past, so I never bothered to instantiate them. No problem adding them and this is the correct place to do so.
I do question the difference in notation here though, for C-style counting from zero for gamma_1..gamma_4 and Fortran-style / physics notation for gamma_5. Should we make these consistent?