Feature/deflated solvers revisit #1015
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed to smart pointers
…sh), fixed bug with incorrect pipeline length assignment for a subtask
2. Merge branch 'develop' into feature/deflated-solvers-revisit Conflicts: include/quda.h
… CA optimized version
|
@alexstrel what's the status of this branch? Now that GK is merged in, we can review this branch once it's brought up to date with develop. |
|
@maddyscientist sorry for the slow response. Agree, I'm synchronizing the branch with the current develop. One hot fix is related to the milc interface, it's disabled in the current feature branch. |
|
@alexstrel there are still a lot of build failures on this PR. I presume I should wait to review once the build tests are passing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focused on the unification of the (old) interface for the legacy deflated solvers (FGMResDR, Inc eigCG) and the new one introduced for the new QUDA eigensolvers.
In addition, it removed all magma library calls so the deflated methods require Eigen library only. The eigCG solver includes CA optimizations based on the predict-and-recompute variant of CG (https://arxiv.org/abs/1905.01549) , while the FGMResDR (and the eigCG in the incremental stage) exploits a compact WY representation for MGS orthogonalization with a lagged normalization of the diagonal of the upper triangular R-matrix.