Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready for Audit] Create ERC721WithOperatorFilterer module #15

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Ready for Audit] Create ERC721WithOperatorFilterer module #15

wants to merge 10 commits into from

Conversation

solcmoon
Copy link

No description provided.

@solcmoon
Copy link
Author

solcmoon commented Jan 25, 2023 •
edited
Loading

Thank you . @deep-quality-dev
I will modify them.

@solcmoon
Copy link
Author

solcmoon commented Feb 2, 2023

@deep-quality-dev
updated README. and added this link in the guide to show the origin NFT contract this module uses.
https://app.bunzz.dev/module-templates/b9754505-40f2-4224-b11f-5a08e152fe97/

@oselezi
Copy link
Contributor

oselezi commented Feb 13, 2023

After you fix those two, I think you can change this PR title to [Ready for Audit] Create ERC721WithOperatorFilterer module.

@solcmoon solcmoon changed the title Create ERC721WithOperatorFilterer module [Ready for Audit] Create ERC721WithOperatorFilterer module Feb 13, 2023
oselezi
oselezi suggested changes Feb 14, 2023
View reviewed changes
.gitignore
@@ -1,3 +1,9 @@
node_modules/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove file here

opensea-operator-filter/.gitmodules
@@ -0,0 +1,9 @@
[submodule "lib/openzeppelin-contracts"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove file here, it will be added to root folder

opensea-operator-filter/.prettierrc Show resolved Hide resolved
opensea-operator-filter/foundry.toml
@@ -0,0 +1,13 @@
[profile.default]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove file

opensea-operator-filter/package.json
@@ -0,0 +1,14 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove file

opensea-operator-filter/yarn.lock
@@ -0,0 +1,8 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deep-quality-dev deep-quality-dev deep-quality-dev left review comments

@oselezi oselezi oselezi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solcmoon @oselezi @deep-quality-dev