Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options are not necessary at Application level #221

Closed
wants to merge 2 commits into from

Conversation

leo108
Copy link

@leo108 leo108 commented Jul 4, 2024

Options like HOST PORT are only useful at server level, config them at app level makes no sense and won't work, so remove them from the default config file to avoid confusion.

@taylorotwell taylorotwell requested a review from joedixon July 4, 2024 14:10
@taylorotwell taylorotwell marked this pull request as draft July 4, 2024 14:10
@joedixon
Copy link
Collaborator

joedixon commented Jul 4, 2024

Thanks for the PR, but these options are required for collecting metrics via Pulse.

@joedixon joedixon closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants