Job Batches with Redis Cluster #54205
Closed
+26
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is not possible to use job batches with Redis Cluster, both with Predis and Phpredis.
PhpRedis does not supports pipelining for Redis Cluster (https://github.com/phpredis/phpredis/blob/develop/cluster.md#pipelining), but supports transaction (making separate transaction for each node, https://github.com/phpredis/phpredis/blob/develop/cluster.md#transactions)
Predis does not supports transactions for Redis Cluster (https://github.com/predis/predis/blob/v2.x/src/Transaction/MultiExec.php#L77). But it pretty well works with pipelining (https://github.com/predis/predis?tab=readme-ov-file#command-pipelines)
This PR uses transaction, pipelining or both, depending on connection type.
Current behaviour is covered with existing tests. But currently i see no way, how to test new behaviour. Currently testing environment does not provide redis cluster.