Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted comma in email.blade.php #54137

Closed
wants to merge 1 commit into from

Conversation

encodiaweb
Copy link

Remove a comma preventing the string ‘Regards’ from being translated correctly when using a locale different form English

Remove a comma preventing the string ‘Regards’ from being translated correctly
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This then makes the English translation incorrect.

@encodiaweb
Copy link
Author

Thank you @GrahamCampbell. "Regards," (with comma) is the correct English term to say "Regards" (Italian: Cordiali Saluti)? I am sorry but I haven't got the point. If you have time, could you explain?

Thank you
Regards

@eleftrik
Copy link

I agree with @encodiaweb. I couldn't get the point: why this makes the English translation incorrect?
@GrahamCampbell do you refer to the missing comma?

I think the right form should be

@lang('Regards'),<br>

Without this PR, why the trailing comma is part of the translatable key?
If I'm not wrong, there is not a key like Regards,, so that string is not translated when using a non-English locale.
In fact, everything is translated into the right language except except Regards,, which remains in English.

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants