[10.x] Fix breaking changes in after validation

[MrPunyapal]

I had a PR #49871 to fix Issue #49863 but from this #49871 (comment) conversation it looks breaking change. also solving Issue #49955

if it is a breaking change then this PR will solve it. added tests for it too.

$v = new Validator($trans, ['y' => '1970-01-01'], ['x' => 'nullable|date', 'y' => 'nullable|date|after:x']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['dates' => [['start_at' => '2024-02-02 12:00:00', 'ends_at' => '2024-02-02 12:00:00']]], ['dates.*.start_at' => 'date', 'dates.*.ends_at' => 'date|after:start_at']);
$this->assertTrue($v->passes());

$v = new Validator($trans, ['date_end' => '2021-09-17 13:28:47'], ['date_start' => 'nullable|date', 'date_end' => 'nullable|date|after_or_equal:date_start']);
$this->assertTrue($v->passes());

Note

last 2 tests were not passing with x, y at place of starts_at or date_start and ends_at or date_end
even if I revert my previous PR #49871 changes.
we can look into that later

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[MrPunyapal]

@calebdw

[calebdw]

This fixes my issue, just added some comments

[MrPunyapal]

it has some weird thing

This fixes my issue, just added some comments

I don't think your issue is fixed?

[calebdw]

Yes, adding ! is_null(...) to the conditions allows my validation test to pass

[MrPunyapal]

Yes, adding ! is_null(...) to the conditions allows my validation test to pass

but that test case is failing?

[iamgergo]

Might be related: #49668