[10.x] Fix $deleteWhenMissingModels on Jobs is ignored when Models use SoftDeletes trait #49807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into account the deletedAt column when retrieving Models from the database on SerializesAndRestoresModelIdentifiers::restoreModel
olml89
force-pushed
the
fix/deletewhenmissingmodels-ignoring-softdeletes
branch
from
009ba74 to
e8954b1
Compare
olml89
changed the title
crynobone
reviewed
Jan 24, 2024
| return $this | ||
| ->newQueryWithoutScopes() | ||
| ->whereKey($ids) | ||
| ->whereNull($this->getDeletedAtColumn()); |
There was a problem hiding this comment.
Wouldn't this break any table without soft-deletes?
|
This would be a breaking change. You can delete the job manually if you want to delete on soft deleted models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to fix this issue: #49794