Skip to content

Commit

Permalink
Moving some TODO comments to MR discussion.
Browse files Browse the repository at this point in the history
  • Loading branch information
BrendanKKrueger committed Sep 30, 2024
1 parent cac4be1 commit 8ab5205
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions spiner/databox.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,6 @@ class DataBox {
PORTABLE_INLINE_FUNCTION T get_data_value(Args... args) const {
return Transform::reverse(dataView_(std::forward<Args>(args)...));
}
// TODO: Should this method be const? Having this be const is in line with the second operator()
// below (the one with const), which allows the user to modify the dependent variable
// values of a const DataBox.
template<typename... Args>
PORTABLE_INLINE_FUNCTION void set_data_value(const T new_value, Args... args) const {
dataView_(std::forward<Args>(args)...) = Transform::forward(new_value);
Expand Down

0 comments on commit 8ab5205

Please sign in to comment.