Fix mean opacities #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
requested review from
pdmullen,
AstroBarker,
brryan and
RyanWollaeger
|
Thanks for going after this! It doesn't seem to be compiling for me with a Debug build with several |
Oops my bad... Didn't run tests. Need to call the constructor in that check. Try now. |
AstroBarker
approved these changes
Jan 2, 2025
brryan
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent MR #58 where runtime physical constants were added, the mean opacities needed to be changed to not look for the compile time constants. I make that modification here. @AstroBarker saw this when trying to update singularity-opac in phoebus.
I know we are likely going to make more changes here soon to support Artemis + Riot but I think it's worth fixing this now, and then we can iterate later as needed.