Add AbsorptionCoefficient and Emissivity to MeanOpacity variants. #59
Conversation
|
@brryan @Yurlungur @pdmullen - this is a preliminary attempt for something that might be used in grey transport. I added the Planck function as a member to the MeanOpacity class, which seems a bit overkill for just emissivity. |
There was a problem hiding this comment.
LGTM! I think the planck/rosseland choice is best made when calling the function, either as you do here with function args, or with different fucntions or a template parameter. What you have here is fine IMO, I just think it's better to not do this in the constructor because we dont want to make the same class twice to call the same data. I'm unconcerned about the different function signatures between mean and non-mean opacity variants, because they have different meanings.
|
@RyanWollaeger what's the status of this MR? |
+ Use gmode input to toggle Rosseland (default) to Planck. + Add PlanckDistribution function as member to MeanOpacity. + Add the new functions to generic and non-CGS MeanOpacity variants. Note: the motivation is to use one of the frequency-integrated opacity values as a grey opacity in transport, which requires using it in both absorption and emissivity, for any choice.
+ Move enum from MeanOpacity class to mean_photon_variant.hpp. + Use Rosseland instead of 0 in variant template function defaults.
RyanWollaeger
force-pushed
the
meanopac_grey_api
branch
from
1766a07 to
08dfff7
Compare
Note: the motivation is to use one of the frequency-integrated opacity values as a grey opacity in transport, which requires using it in both absorption and emissivity, for any choice.