Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-CGS constants #58

Merged
merged 10 commits into from
Dec 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
working
brryan committed Dec 10, 2024
commit e9063ff419f5678b9359590104c1a90284589092
2 changes: 1 addition & 1 deletion singularity-opac/neutrinos/neutrino_variant.hpp
Original file line number Diff line number Diff line change
@@ -76,7 +76,7 @@ class Variant {
return mpark::visit(
[=](const auto &opac) {
using PC = typename std::decay_t<decltype(opac)>::PC;
return singularity::GetRuntimePhysicalConstants(PC());
return RuntimePhysicalConstants(PC());
},
opac_);
}
3 changes: 3 additions & 0 deletions test/test_gray_opacities.cpp
Original file line number Diff line number Diff line change
@@ -109,6 +109,9 @@ TEST_CASE("Gray neutrino opacities", "[GrayNeutrinos]") {
neutrinos::Gray(1), time_unit, mass_unit, length_unit, temp_unit);
auto funny_units = funny_units_host.GetOnDevice();

auto noncgs_rpc = funny_units.GetRuntimePhysicalConstants();
printf("ar: %e\n", noncgs_rpc.ar);

THEN("We can convert meaningfully into and out of funny units") {
int n_wrong_h = 0;
#ifdef PORTABILITY_STRATEGY_KOKKOS