SetupDeps before SetupOptions #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI says yes this change is necessary. Let me see if I can fix in a CUDA-friendly way. |
|
I don't remember making this change. Do both cuda and the CI like it now? |
|
@Yurlungur yeah this compiles for me with cuda and the CI seems happy. I think it is ready for review/merge. |
Yurlungur
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts a recent change so that
SetupDepsprecedesSetupOptionsinCMakeLists. This change was made in #47 but it's breaking GPU compilation for me (the code findsCUDAToolkitinSetupDepsand checks forCUDA::toolkitinSetupOptions. @Yurlungur I'm not sure why this change was made, is it safe to revert?