Start adding tests

lanl · Dec 10, 2024 · 49fc726 · 49fc726
1 parent 06c62e3
commit 49fc726
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/singularity-opac/photons/photon_variant.hpp b/singularity-opac/photons/photon_variant.hpp
@@ -75,8 +75,7 @@ class Variant {
   GetRuntimePhysicalConstants() const {
     return mpark::visit(
         [](auto &opac) {
-          using PC = typename std::decay_t<decltype(opac)>::PC;
-          return RuntimePhysicalConstants(PC());
+          return opac.GetRuntimePhysicalConstants();
         },
         opac_);
   }

diff --git a/singularity-opac/photons/powerlaw_opacity_photons.hpp b/singularity-opac/photons/powerlaw_opacity_photons.hpp
@@ -174,6 +174,11 @@ class PowerLawOpacity {
     return dist_.NumberDensityFromTemperature(temp, lambda);
   }
 
+  PORTABLE_INLINE_FUNCTION RuntimePhysicalConstants
+  GetRuntimePhysicalConstants() const {
+    return RuntimePhysicalConstants(PC());
+  }
+
  private:
   Real kappa0_;   // Opacity scale. Units of cm^2/g
   Real rho_exp_;  // Power law index of density

diff --git a/test/test_gray_opacities.cpp b/test/test_gray_opacities.cpp
@@ -109,9 +109,6 @@ TEST_CASE("Gray neutrino opacities", "[GrayNeutrinos]") {
               neutrinos::Gray(1), time_unit, mass_unit, length_unit, temp_unit);
       auto funny_units = funny_units_host.GetOnDevice();
 
-      auto noncgs_rpc = funny_units.GetRuntimePhysicalConstants();
-      printf("ar: %e\n", noncgs_rpc.ar);
-
       THEN("We can convert meaningfully into and out of funny units") {
         int n_wrong_h = 0;
 #ifdef PORTABILITY_STRATEGY_KOKKOS
@@ -272,6 +269,11 @@ TEST_CASE("Gray photon opacities", "[GrayPhotons]") {
           photons::Gray(1), time_unit, mass_unit, length_unit, temp_unit);
       auto funny_units = funny_units_host.GetOnDevice();
 
+      THEN("We can retrieve physical constants in code units") {
+        auto noncgs_rpc = funny_units.GetRuntimePhysicalConstants();
+        REQUIRE(FractionalDifference(noncgs_rpc.ar, 1.980493e-10) < EPS_TEST);
+      }
+
       THEN("We can convert meaningfully into and out of funny units") {
         int n_wrong_h = 0;
 #ifdef PORTABILITY_STRATEGY_KOKKOS