Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected sparse packs 1 #193

Merged
merged 9 commits into from
Dec 14, 2023
Merged

Selected sparse packs 1 #193

merged 9 commits into from
Dec 14, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Dec 12, 2023

PR Summary

This is another step on the great refactor. Here I just move some dense packs to sparse packs, and in the process move those tasks into the synchronous region of the task list, i.e., they pack over blocks.

This is showing what can be done with #191 now in place. I am doing the migration piece by piece, and so we can merge this in before I (or someone else) moves to doing, e.g., the Riemann solver and reconstruction, which will be the biggest lift.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by calling scripts/bash/format.sh.
  • Explain what you did.

Copy link
Collaborator

@brryan brryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

src/fluid/fluid.cpp Outdated Show resolved Hide resolved
src/fluid/fluid.cpp Show resolved Hide resolved
Copy link
Collaborator

@carlnotsagan carlnotsagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my limited knowledge this looks good! only thing i saw was the call to get the coords in par_for in fluid.cpp but im assuming that was intentional. thanks for this improvement, jonah!

@Yurlungur Yurlungur merged commit 7b56701 into main Dec 14, 2023
2 checks passed
@Yurlungur Yurlungur deleted the jmm/selected-sparse-packs-1 branch December 14, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants