-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selected sparse packs 1 #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my limited knowledge this looks good! only thing i saw was the call to get the coords in par_for in fluid.cpp but im assuming that was intentional. thanks for this improvement, jonah!
PR Summary
This is another step on the great refactor. Here I just move some dense packs to sparse packs, and in the process move those tasks into the synchronous region of the task list, i.e., they pack over blocks.
This is showing what can be done with #191 now in place. I am doing the migration piece by piece, and so we can merge this in before I (or someone else) moves to doing, e.g., the Riemann solver and reconstruction, which will be the biggest lift.
PR Checklist
scripts/bash/format.sh
.