Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units #4

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Units #4

merged 7 commits into from
Dec 12, 2024

Conversation

brryan
Copy link
Collaborator

@brryan brryan commented Dec 12, 2024 •
edited
Loading

Background

We want to fully support host code code units with some conversion factors to CGS.

Description of Changes

  • Switch mcblock opacity variants to NonCGS<> only.
  • Provide unit conversion factors as mcblock driver input parameters.
  • Actually add e-p bremsstrahlung opacity as a mcblock option
  • Code unit physical constants are actually already entirely handled by extracting constants from singularity-opac variants
  • Switch to latest singularity-opac with support for runtime physical constants generalized to non-cgs units
  • Update Parthenon to Kokkos 4.5 version

Checklist

  • New features are documented
  • Tests added for bug fixes and new features
  • (@lanl.gov employees) Update copyright on changed files
  • Corresponding singularity-opac PR is merged

pdmullen
pdmullen approved these changes Dec 12, 2024
View reviewed changes
src/mcblock/mcblock.cpp Show resolved Hide resolved
src/mcblock/mcblock.cpp Outdated Show resolved Hide resolved
@brryan brryan merged commit 8a2fd66 into develop Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdmullen pdmullen pdmullen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brryan @pdmullen