Use Hopcroft-Karp matching algorithm #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 97.69% 97.66% -0.03%
==========================================
Files 8 8
Lines 304 343 +39
==========================================
+ Hits 297 335 +38
- Misses 7 8 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Failing test is coverage. There is an error we throw if Hopcroft-Karp encounters a non-bipartite graph that we never hit. This seems fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of the Hopcroft-Karp bipartite matching algorithm to fix the performance issues noted in #8. This implementation is a placeholder until JuliaGraphs/Graphs.jl#291 is merged.
It also fixes a quadratic loop in
dulmage_mendelsohndue to repeatedly checking inclusion in a vector.