Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

fix about me card beyond height limit #23

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Addison1
Copy link
Contributor

Pull Request Template

The iPhone SE encounters an issue where the content overflows beyond the interface. Due to the inability to simulate on the Mac platform (equipment issues), I observed similar problems with devices having close screen sizes. Therefore, I will use the Android small phone emulator as the standard for fixing this issue.

Briefly describe the changes and the related issue.

Related Issue

Link to the issue here: #(issue)

Type of Change

  • [V] Bug fix (fix)
  • New feature (feat)

Checklist

  • [V] Code follows project guidelines
  • Self-reviewed code

Additional Notes

Any additional information.

Reviewers

xue,d5

@Addison1
Copy link
Contributor Author

previous view
Screenshot_9

Copy link
Member

@xuelink xuelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i merge but when the user have long about me text,
constraints.maxHeight > 550 ? 550 : constraints.maxHeight;
should be updated i guess.

@xuelink xuelink merged commit 76a6825 into main Jun 25, 2024
1 check passed
@xuelink xuelink deleted the bug-about-me-card-beyond branch June 25, 2024 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants