Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-PT] Added compound words to AO45 and AO90 #48

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

marcoagpinto
Copy link
Member

Heya, @p-goulart

So, this was it?

I thought I would have to search for the compounds files, but they were in a folder right in front of me.

😛 😛 😛 😛 😛 😛

@marcoagpinto marcoagpinto added the enhancement New feature or request label Jul 27, 2024
@marcoagpinto
Copy link
Member Author

Heya, @p-goulart

LanguageTool entered feature freeze today, could you approve these changes before the official release?

Thanks!

@marcoagpinto
Copy link
Member Author

@p-goulart

Thank you for approving, but you must merge it because I have no access to that command in this repository.

I was just waiting for this pull request to be approved so that I could start working slowly in adding words and postags.

I will be adding words and postags slowly and updating the files so that in a next dictionary/postag release, the WIP can be merged as a whole.

Thanks!

@p-goulart
Copy link
Collaborator

@marcoagpinto, I have granted you rights to bypass pull request approvals. I'm keeping in place the requirement that tests pass, however.

Please make sure the pipeline is successful so we know for a fact the changes are not detrimental. In this case, if you read the message, it simply means pointing the GitHub Actions configuration to a valid branch by changing the value of the LT_BRANCH variable. If you don't have a feature branch on the main LT repo yet, simply master should do the trick.

@marcoagpinto
Copy link
Member Author

@p-goulart

I still don't have the knowledge on how to fix this pull request.

The best way of fixing it is by closing it, then I will create another checkout and will start adding the words/postags missing including the ones here.

Thanks!

❤️ ❤️ ❤️ ❤️ ❤️

@marcoagpinto
Copy link
Member Author

@p-goulart

Help!

My clone of the repository... I only see "main" in the branch.

Should I in Tortoise Git press to commit to "main"?

Will this create a pull request or immediately merge the commit?

I need to be sure so that I don't screw up.

Thanks!

@p-goulart
Copy link
Collaborator

I still don't have the knowledge on how to fix this pull request.

I told you how here:

pointing the GitHub Actions configuration to a valid branch by changing the value of the LT_BRANCH variable. If you don't have a feature branch on the main LT repo yet, simply master should do the trick.

To spell it out:

  • go to .github/workflows/build.yml;
  • on line 34, you should see:
LT_BRANCH: "pt/dict/v1.2.0"
  • this branch is outdated (it was for a specific release, as per the README);
  • change that to master.

The best way of fixing it is by closing it

This is not true. You can open and close this PR as many times as you want, and so long as the GHA config points to a non-existing LT branch, the tests will not magically fix themselves...

Should I in Tortoise Git press to commit to "main"?

Please do not commit straight to main. See the point below.


Alternatively, add your words to the spelling and added files in the LT repo and request @susanaboatto's approval. It'll work as a hotfix. When the time comes to release a new dictionary, I can move the words here myself, prepare the release, make sure all tests pass, and trigger the deployment.

That way, you'll get to suggest your improvements without having to contribute to this repo.

@marcoagpinto marcoagpinto reopened this Oct 5, 2024
@p-goulart p-goulart force-pushed the lt_marcoagpinto_20240727_0401 branch from 6dd9608 to 0fe22f8 Compare October 7, 2024 08:37
@p-goulart
Copy link
Collaborator

I've rebased this on the fixed main branch with the latest LT snapshot and the correct LT upstream master branch.

@marcoagpinto marcoagpinto merged commit 9a492aa into main Oct 7, 2024
7 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20240727_0401 branch October 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants