Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

wants to merge 2 commits into from

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Sep 12, 2024 •
edited by coderabbitai bot
Loading

Heya, @susanaboatto and @p-goulart ,

I have added an AP and fixed/improved two others.

Summary by CodeRabbit

  • New Features

    • Introduced a new antipattern for the phrase "para tal" to improve grammar detection in Portuguese.

  • Improvements

    • Enhanced accuracy of grammar checking by normalizing postag patterns across multiple tokens.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 12, 2024 •
edited
Loading

Walkthrough

The pull request introduces modifications to the Portuguese language module of LanguageTool, specifically in the grammar.xml file. A new antipattern targeting the phrase "para tal" has been added, along with adjustments to existing antipatterns that normalize postag patterns for improved accuracy. These changes enhance the grammar checking capabilities of the module by refining the detection of specific phrases and ensuring correct postag formatting.

Changes

File Path Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml Added a new antipattern for "para tal" and modified postag patterns from (SPS00)?: to (SPS00:)?.

Possibly related PRs

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0354faf and e0e4116.

Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Sep 12, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)

Line range hint 1-1: Code changes are missing. Please provide the annotated code for review.

The annotated code section is empty, indicating that the code changes have not been provided. Without the code changes, it is not possible to perform a detailed review of the file.

Please update the pull request with the annotated code, including the line numbers and ~ signs to indicate the added or modified lines. This will allow me to generate accurate review comments on each changed code segment.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 70f8f5f and 0354faf.

Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)

susanaboatto
susanaboatto reviewed Sep 12, 2024
View reviewed changes
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
<token>tal</token>
<token postag='(SPS00:)?[DP]...[PN].+|VM...P.+' postag_regexp='yes'/>
<token postag="AQ..[PN].+|N..[PN].+|Z0.[PN].+|(SPS00:)?[DP]...[PN].+|VM...P.+" postag_regexp="yes"/>
<example>Quero para tal esses dois telemóveis.</example>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also work with "para tanto"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susanaboatto

Done!

@marcoagpinto
Copy link
Member Author

@susanaboatto

Any feedback on this one?

Thanks!

@marcoagpinto
Copy link
Member Author

Heya, @p-goulart and @susanaboatto

LanguageTool entered feature freeze today, could one of you approve these changes before the official release?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

@p-goulart p-goulart Awaiting requested review from p-goulart

@susanaboatto susanaboatto Awaiting requested review from susanaboatto

Assignees
No one assigned
Labels
Portuguese
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcoagpinto @susanaboatto