[en] improve EN_A_VS_AN #10358
Draft
[en] improve EN_A_VS_AN #10358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnaber
reviewed
Feb 29, 2024
| @@ -95,6 +95,11 @@ public RuleMatch[] match(AnalyzedSentence sentence) { | |||
| } | |||
| if (equalsA || equalsAn) { | |||
| Determiner determiner = getCorrectDeterminerFor(token); | |||
| if (token.getToken().equals("EUR") && i < tokens.length - 1) { | |||
| determiner = getCorrectDeterminerFor(tokens[i + 1]); | |||
| } else if (token.getToken().equals("EUR") && i == tokens.length - 1) { | |||
There was a problem hiding this comment.
There's no test for this case, or am I missing something?
| @@ -95,6 +95,11 @@ public RuleMatch[] match(AnalyzedSentence sentence) { | |||
| } | |||
| if (equalsA || equalsAn) { | |||
| Determiner determiner = getCorrectDeterminerFor(token); | |||
| if (token.getToken().equals("EUR") && i < tokens.length - 1) { | |||
There was a problem hiding this comment.
Maybe add a comment with an example here, as this is quite clever but maybe a bit difficult to understand by just looking at the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "a" or "an" is followed by "EUR", look to the next token to determine the correct determiner.
I needed to add "100" to
det_a.txtto make the 3rd example work:assertIncorrect("The company has also entered into an EUR 100 million ($88 million) debt");Not sure why I had to do this, but I do notice that:
is not caught by this particular rule either.
Maybe there's a blind spot with certain numerical values.