Build JS and CSS in CI #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because 2.0 does not build on Travis CI.
|
I think it would be ideal to use |
|
Good point! Fixed. |
|
I'm also going to drop node_modules from the cache as npm ci deletes it anyway: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, laravel-mix does not run in CI. This means that, for instance, a broken commit or merge will not be detected until a developer tries running it locally.
This adds a script step to install NPM and run a production laravel-mix build. If any errors occur, this causes the build to fail. I suspect this was the original intention given that .travis.yml specifies that node_modules be cached, which is not populated as far as I am aware.
As part of this, I had to upgrade laravel-mix as 2.0 does not build on Travis CI (node-sass binding problems).
Note that there are still committed (development) JS and CSS files in the public directory; I am not certain what these are used for. As there is no deployment step, the artifacts produced by laravel-mix are discarded at the end of the build.