Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(api): optimize token read/write during api call #9951

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

perf(api): optimize token read/write during api call #9951

wants to merge 6 commits into from
+46 −10

Conversation

aconeshana
Copy link

@aconeshana aconeshana commented Oct 28, 2024 •
edited by crazywoola
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  1. Since Dify uses Redis, token authentication can be optimized by storing it in Redis.
  2. Each time a token is used, the last updated timestamp will be refreshed asynchronously via Celery.

Closes #9950

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 28, 2024
@aconeshana
Copy link
Author

related issue: #9950

crazywoola
crazywoola reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola left review comments

@laipz8200 laipz8200 Awaiting requested review from laipz8200

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
💪 enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api-token use performance enhance
2 participants
@aconeshana @crazywoola