fix: redundant check for available_document_count #8491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
crazywoola
approved these changes
Sep 22, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Sep 23, 2024
* main: (64 commits) chore: Enable Japanese descriptions for Tools (#8646) Make WORKFLOW_* configurable as environment variables. (#8644) feat: add deepseek-v2.5 for model provider siliconflow (#8639) docs: fix predefined_model_scale_out.md redirect error (#8633) feat: add qwen2.5 for model provider siliconflow (#8630) fix: send message error when chatting with opening statement (#8627) fix: llm_generator.py JSONDecodeError (#8504) fix: commands.py (#8483) fix: redundant check for available_document_count (#8491) chore: enhance configuration descriptions (#8624) chore: add Gemini newest experimental models (close #7121) (#8621) feat: support o1 series models for openrouter (#8358) fix: form input add tabIndex (#8478) Add model parameter translation (#8509) feat(tools/cogview): Updated cogview tool to support cogview-3 and the latest cogview-3-plus (#8382) Add Fireworks AI as new model provider (#8428) feat:use xinference tts stream mode (#8616) docs: Add Japanese documentation for tools (#8469) feat: regenerate in `Chat`, `agent` and `Chatflow` app (#7661) feat: update pyproject.toml (#8368) ...
hgnulb
pushed a commit
to hgnulb/dify
that referenced
this pull request
Sep 26, 2024
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
Removed duplicate check for dataset.available_document_count in the retrieval process. The condition now correctly checks if available_document_count is zero only once.
Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration