Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: commands.py #8483

Merged
merged 2 commits into from
Sep 22, 2024
Merged

fix: commands.py #8483

merged 2 commits into from
Sep 22, 2024

Conversation

ZuzooVn
Copy link
Contributor

@ZuzooVn ZuzooVn commented Sep 16, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Enhance command's message and fix bug for new_email validation

  • before
    try:
        email_validate(new_email)
    except:
        click.echo(click.style("sorry. {} is not a valid email. ".format(email), fg="red"))
  • after
    try:
        email_validate(new_email)
    except:
        click.echo(click.style("Invalid email: {}".format(new_email), fg="red"))

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐍 python 🐞 bug Something isn't working 💪 enhancement New feature or request labels Sep 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 22, 2024
@crazywoola crazywoola merged commit 6e37750 into langgenius:main Sep 22, 2024
6 checks passed
@ZuzooVn ZuzooVn deleted the enhance-commands.py branch September 22, 2024 06:31
ZhouhaoJiang added a commit that referenced this pull request Sep 23, 2024
@ZhouhaoJiang
Merge branch 'main' into feat/new-login
f6f6bb1 
* main: (64 commits)
  chore: Enable Japanese descriptions for Tools (#8646)
  Make WORKFLOW_* configurable as environment variables. (#8644)
  feat: add deepseek-v2.5 for model provider siliconflow (#8639)
  docs: fix predefined_model_scale_out.md redirect error (#8633)
  feat: add qwen2.5 for model provider siliconflow (#8630)
  fix: send message error when chatting with opening statement (#8627)
  fix: llm_generator.py JSONDecodeError (#8504)
  fix: commands.py (#8483)
  fix: redundant check for available_document_count (#8491)
  chore: enhance configuration descriptions (#8624)
  chore: add Gemini newest experimental models (close #7121) (#8621)
  feat: support o1 series models for openrouter (#8358)
  fix: form input add tabIndex (#8478)
  Add model parameter translation (#8509)
  feat(tools/cogview):  Updated cogview tool to support cogview-3 and the latest cogview-3-plus (#8382)
  Add Fireworks AI as new model provider (#8428)
  feat:use xinference tts stream mode (#8616)
  docs: Add Japanese documentation for tools (#8469)
  feat: regenerate in `Chat`, `agent` and `Chatflow` app (#7661)
  feat: update pyproject.toml (#8368)
  ...
hgnulb pushed a commit to hgnulb/dify that referenced this pull request Sep 26, 2024
@ZuzooVn
fix: commands.py (langgenius#8483)
e636a2f
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
@ZuzooVn @cuiks
fix: commands.py (langgenius#8483)
dea509b
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@ZuzooVn @lau-td
fix: commands.py (langgenius#8483)
999161d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working 💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZuzooVn @crazywoola