Skip to content

Conversation

@qiaofenlin
Copy link
Contributor

@qiaofenlin qiaofenlin commented Jan 20, 2026

  • Add list type validation for checkbox multi-select parameters
  • Align ToolInput validation with TriggerEventInput behavior
  • Fix ValidationError when using checkbox type tool parameters

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Fixes #31282

Summary

This PR fixes a validation error when using checkbox (multi-select) type parameters in tool nodes.

Problem

When a tool node has a checkbox parameter, executing the workflow fails with:

ValidationError: 1 validation error for ToolInput type Value error, value must be a string, int, float, bool or dict

Root Cause

Checkbox multi-select controls store values as arrays (e.g., ['female']), but the ToolInput validator in tool nodes did not support list type, while TriggerEventInput in trigger nodes already does.

Comparison:

Node Type Supported value types
Trigger Node (TriggerEventInput) str, int, float, bool, dict, list
Tool Node (ToolInput) str, int, float, bool, dict

Solution

Add list type support to ToolInput.check_type() validator to align with TriggerEventInput behavior.

Changes

  • api/core/workflow/nodes/tool/entities.py: Add list type validation for constant value in ToolInput

Screenshots

Before After
image image
ValidationError when using checkbox parameters in tool node Tool node executes successfully with checkbox parameters

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

- Add list type validation for checkbox multi-select parameters
- Align ToolInput validation with TriggerEventInput behavior
- Fix ValidationError when using checkbox type tool parameters
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @qiaofenlin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical validation issue within the workflow system, specifically concerning tool nodes that utilize multi-select checkbox parameters. Previously, these parameters, which inherently produce list-type values, were not correctly validated by the ToolInput mechanism, leading to runtime errors. The change introduces support for list-type constant values in ToolInput, harmonizing its validation logic with that of TriggerEventInput and thereby enabling seamless execution of workflows with such configurations.

Highlights

  • Fix Validation Error: Resolves a ValidationError that occurred when using checkbox (multi-select) type parameters in tool nodes, which previously failed due to unsupported list values.
  • Align ToolInput Validation: Adds list type support to the ToolInput.check_type() validator, bringing its behavior in line with TriggerEventInput which already supported list types.
  • Enhanced Workflow Robustness: Ensures that workflows utilizing multi-select checkbox parameters in tool nodes can execute successfully without encountering type validation issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the ValidationError for checkbox multi-select parameters in tool nodes by adding list to the allowed types for ToolInput constants. The change is straightforward and aligns ToolInput with TriggerEventInput as intended. I have one suggestion to improve the maintainability of the type validation logic.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool node fails with ValidationError when using checkbox (multi-select) type parameters

1 participant