-
Notifications
You must be signed in to change notification settings - Fork 19.7k
fix: add list type support for ToolInput constant value in tool node #31276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add list type support for ToolInput constant value in tool node #31276
Conversation
- Add list type validation for checkbox multi-select parameters - Align ToolInput validation with TriggerEventInput behavior - Fix ValidationError when using checkbox type tool parameters
Summary of ChangesHello @qiaofenlin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical validation issue within the workflow system, specifically concerning tool nodes that utilize multi-select checkbox parameters. Previously, these parameters, which inherently produce list-type values, were not correctly validated by the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses the ValidationError for checkbox multi-select parameters in tool nodes by adding list to the allowed types for ToolInput constants. The change is straightforward and aligns ToolInput with TriggerEventInput as intended. I have one suggestion to improve the maintainability of the type validation logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Important
Fixes #<issue number>.Fixes #31282
Summary
This PR fixes a validation error when using checkbox (multi-select) type parameters in tool nodes.
Problem
When a tool node has a checkbox parameter, executing the workflow fails with:
Root Cause
Checkbox multi-select controls store values as arrays (e.g.,
['female']), but theToolInputvalidator in tool nodes did not supportlisttype, whileTriggerEventInputin trigger nodes already does.Comparison:
TriggerEventInput)str,int,float,bool,dict,list✅ToolInput)str,int,float,bool,dict❌Solution
Add
listtype support toToolInput.check_type()validator to align withTriggerEventInputbehavior.Changes
api/core/workflow/nodes/tool/entities.py: Addlisttype validation for constant value inToolInputScreenshots
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods