-
Notifications
You must be signed in to change notification settings - Fork 19.7k
feat: add file origin type #31197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add file origin type #31197
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug where file type validation would fail in multi-turn conversations. The issue arose because a file initially classified as 'custom' could be re-evaluated to a more specific type (e.g., 'image') during subsequent processing, causing validation checks to incorrectly reject it. The solution involves introducing an Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an original_type field to the File model to preserve the file type specified during upload, which is a good approach to fix the validation issue. The changes are logical and correctly address the problem. I've left a few comments with suggestions to improve code quality by removing redundancy and simplifying logic. Overall, this is a good contribution.
Important
Fixes #<issue number>.Summary
fix #31099
in second conversation
build_from_message_filethe type become image, so the check_is_file_valid_with_configfailScreenshots
before
Screen.Recording.2026-01-19.at.10.48.48.mov
after
Screen.Recording.2026-01-19.at.10.44.42.mov
Checklist
make lintandmake type-check(backend) andcd web && npx lint-staged(frontend) to appease the lint gods