Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model_runtime): fix wrong max_tokens for Claude 3.5 Haiku on Amazon Bedrock #10286

Merged

Conversation

mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 5, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

I've added Claude 3.5 Haiku on Amazon Bedrock (#10265).
But max_token is wrong. It was set to 4096, but it should have been 8192.
I apologize for not checking thoroughly.

https://docs.anthropic.com/en/docs/about-claude/models#model-comparison-table

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@crazywoola crazywoola merged commit cb245b5 into langgenius:main Nov 5, 2024
6 checks passed
@mazyu36 mazyu36 deleted the fix/bedrock-haiku-3-5-max-tokens branch November 5, 2024 06:58
BenjaminX pushed a commit to BenjaminX/ben-dify that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants