Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(document_extractor): support tool file in document extractor #10217

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

laipz8200
Copy link
Collaborator

Checklist:

Important

Please review the checklist below before submitting your pull request.

Description

  • Remove redundant check for local file transfer method.
  • Simplify logic by directly using file_manager.download for unsupported methods.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Remove redundant check for local file transfer method.
- Simplify logic by directly using `file_manager.download` for unsupported methods.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Nov 3, 2024
@laipz8200 laipz8200 changed the title feat(document_extractor): streamline file download logic feat(document_extractor): support tool file in document extractor Nov 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@crazywoola crazywoola merged commit 2c4d8db into main Nov 5, 2024
9 checks passed
@crazywoola crazywoola deleted the feat/streamline-file-download-logic branch November 5, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants