fix(tongyi): fix credentials access and temp file upload compatibility #2507

Dnoob · 2026-01-28T10:24:34Z

Summary

Fix two bugs in _upload_file_to_tongyi method:

credentials.dashscope_api_key causes 'dict' object has no attribute 'dashscope_api_key' error when
using Agent node with memory enabled
tempfile._TemporaryFileWrapper is not compatible with new OpenAI SDK file upload

Related Issues or Context

Qwen-Long model PluginInvokeError: 'dict' object has no attribute 'dashscope_api_key' #1290
PluginInvokeError when transforming agent message: "read llm model failed" with Tongyi model #1110

This PR contains Changes to Non-Plugin

Documentation
Other

This PR contains Changes to Non-LLM Models Plugin

I have Run Comprehensive Tests Relevant to My Changes

This PR contains Changes to LLM Models Plugin

My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and
Agent Node)
My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
My Changes Affect Structured Output Format (JSON, XML, etc.)
My Changes Affect Token Consumption Metrics
My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
Other Changes (Add New Models, Fix Model Parameters etc.)

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

I have Bumped Up the Version in Manifest.yaml (Top-Level Version Field, Not in Meta Section)

Dify Plugin SDK Version

I have Ensured dify_plugin>=0.3.0,<0.6.0 is in requirements.txt

Environment Verification (If Any Code Changes)

Local Deployment Environment

Dify Version is: 1.8.1, I have Tested My Changes on Local Deployment Dify with a Clean Environment That
Matches the Production Configuration.

- Change credentials.dashscope_api_key to credentials["dashscope_api_key"] - Fix temp file upload for OpenAI SDK compatibility by reopening with open() - Bump version to 0.1.22

gemini-code-assist · 2026-01-28T10:24:50Z

Summary of Changes

Hello @Dnoob, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two critical bugs within the Tongyi plugin's file upload functionality. It rectifies an incorrect method of accessing the dashscope_api_key that caused errors when the Agent node was used with memory enabled. Additionally, it resolves an incompatibility issue where tempfile._TemporaryFileWrapper objects were not properly handled by the new OpenAI SDK during file uploads, ensuring robust multimodal input processing.

Highlights

Credential Access Fix: Corrected the access method for dashscope_api_key within the _upload_file_to_tongyi function, changing from attribute access (credentials.dashscope_api_key) to dictionary key access (credentials["dashscope_api_key"]) to prevent errors when using the Agent node with memory enabled.
Temporary File Upload Compatibility: Updated the file upload mechanism in _upload_file_to_tongyi to ensure compatibility with the OpenAI SDK. This resolves issues where tempfile._TemporaryFileWrapper objects were not properly handled, by explicitly reopening the temporary file in binary read mode before uploading.
Plugin Version Bump: The Tongyi plugin version in manifest.yaml has been incremented from 0.1.21 to 0.1.22.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request addresses two bugs within the _upload_file_to_tongyi method: an incorrect attribute access on the credentials dictionary and a file upload compatibility issue with the OpenAI SDK. The fixes are correct and effectively resolve the described problems. I have included one suggestion to refactor the OpenAI client instantiation to improve code clarity and reduce duplication.

gemini-code-assist · 2026-01-28T10:27:49Z

models/tongyi/models/llm/llm.py

        client = OpenAI(
-            api_key=credentials.dashscope_api_key,
+            api_key=credentials["dashscope_api_key"],
            base_url="https://dashscope.aliyuncs.com/compatible-mode/v1",
        )
        if credentials.get("use_international_endpoint", "false") == "true":
            client = OpenAI(
-                api_key=credentials.dashscope_api_key,
+                api_key=credentials["dashscope_api_key"],
                base_url="https://dashscope-intl.aliyuncs.com/compatible-mode/v1",
            )


To improve maintainability and reduce code duplication, you can determine the base_url first and then instantiate the OpenAI client once. This avoids repeating the client instantiation logic.

Suggested change

client = OpenAI(

api_key=credentials.dashscope_api_key,

api_key=credentials["dashscope_api_key"],

base_url="https://dashscope.aliyuncs.com/compatible-mode/v1",

)

if credentials.get("use_international_endpoint", "false") == "true":

client = OpenAI(

api_key=credentials.dashscope_api_key,

api_key=credentials["dashscope_api_key"],

base_url="https://dashscope-intl.aliyuncs.com/compatible-mode/v1",

)

base_url = (

"https://dashscope-intl.aliyuncs.com/compatible-mode/v1"

if credentials.get("use_international_endpoint", "false") == "true"

else "https://dashscope.aliyuncs.com/compatible-mode/v1"

)

client = OpenAI(

api_key=credentials["dashscope_api_key"],

base_url=base_url,

)

fix(tongyi): fix credentials access and temp file upload compatibility

6202373

- Change credentials.dashscope_api_key to credentials["dashscope_api_key"] - Fix temp file upload for OpenAI SDK compatibility by reopening with open() - Bump version to 0.1.22

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 28, 2026

Dnoob temporarily deployed to models/tongyi January 28, 2026 10:24 — with GitHub Actions Inactive

dosubot bot added the bug Something isn't working label Jan 28, 2026

gemini-code-assist bot reviewed Jan 28, 2026

View reviewed changes

Merge branch 'main' into fix/tongyi-credentials-and-file-upload

beed6b7

crazywoola had a problem deploying to models/tongyi January 29, 2026 02:53 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tongyi): fix credentials access and temp file upload compatibility #2507

fix(tongyi): fix credentials access and temp file upload compatibility #2507

Uh oh!

Dnoob commented Jan 28, 2026

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(tongyi): fix credentials access and temp file upload compatibility #2507

Are you sure you want to change the base?

fix(tongyi): fix credentials access and temp file upload compatibility #2507

Uh oh!

Conversation

Dnoob commented Jan 28, 2026

Summary

Related Issues or Context

This PR contains Changes to Non-Plugin

This PR contains Changes to Non-LLM Models Plugin

This PR contains Changes to LLM Models Plugin

Version Control (Any Changes to the Plugin Will Require Bumping the Version)

Dify Plugin SDK Version

Environment Verification (If Any Code Changes)

Local Deployment Environment

Uh oh!

gemini-code-assist bot commented Jan 28, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants