-
Notifications
You must be signed in to change notification settings - Fork 701
fix: 404 on nested groups (>2 levels) and missing slash in raw file URL #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ed groups
- repository/files{path} -> repository/files/{path}
- quote(identifier, safe='') -> identifier.replace('/', '%2F')
Fixes 404 on GitLab with nested groups (>=3 levels) and single file fetch.
Summary of ChangesHello @joeyhacker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two distinct but related issues causing 404 errors when interacting with GitLab repositories. It refines how project identifiers are URL-encoded to correctly handle deeply nested group structures and corrects a malformed URL used for fetching raw file content. The overall impact is enhanced reliability and broader compatibility for accessing files and repositories within GitLab. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses two separate 404 errors when interacting with the GitLab API. The first fix correctly adds a missing slash to the raw file URL, resolving an issue when fetching file content. The second fix changes the URL encoding method for repository identifiers to support nested groups. While this may solve an issue with older GitLab instances as described, the new method is less robust as it only encodes slashes and will fail for repository paths containing other special characters like spaces. I've left a comment with a suggestion to revert to the more standard and safer URL encoding function to prevent future issues.
revert: restore standard URL encoding for repository identifier Revert the incorrect change from urllib.parse.quote to str.replace. The standard quote function correctly handles all special characters and is not the root cause of the 404 issue. The actual fixes needed are: - Pass project_id instead of project string to fetch_files - Add missing slash in raw file URL path Keep urllib.parse.quote(identifier, safe=\"\") as the robust encoding method. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Problem
When repository is filled with a 3-level group path like Bigdata/vcrm/SparkStreaming, the plugin URL-encodes the whole string → Bigdata%2Fvcrm%2FSparkStreaming; old GitLab instances return 404 for such "deep" encoded paths.
When fetching single file content, the raw-url is built as …/repository/files{path}/raw (no slash), causing another 404.
Root cause
urllib.parse.quote(identifier, safe="") encodes all slashes.
String concatenation forgets a separator / before {encoded_item_path}.
Solution
Replace full quote with identifier.replace("/", "%2F") to keep only two levels.
Add missing / in raw-file URL template.
Result
Nested-group repos can now be traversed and single files downloaded without 404.
No breaking change for existing 2-level or numeric-id usages.
Closes #