Skip to content

Conversation

@joeyhacker
Copy link

Problem
When repository is filled with a 3-level group path like Bigdata/vcrm/SparkStreaming, the plugin URL-encodes the whole string → Bigdata%2Fvcrm%2FSparkStreaming; old GitLab instances return 404 for such "deep" encoded paths.
When fetching single file content, the raw-url is built as …/repository/files{path}/raw (no slash), causing another 404.
Root cause
urllib.parse.quote(identifier, safe="") encodes all slashes.
String concatenation forgets a separator / before {encoded_item_path}.
Solution
Replace full quote with identifier.replace("/", "%2F") to keep only two levels.
Add missing / in raw-file URL template.
Result
Nested-group repos can now be traversed and single files downloaded without 404.
No breaking change for existing 2-level or numeric-id usages.
Closes #

…ed groups

- repository/files{path} -> repository/files/{path}
- quote(identifier, safe='') -> identifier.replace('/', '%2F')

Fixes 404 on GitLab with nested groups (>=3 levels) and single file fetch.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joeyhacker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two distinct but related issues causing 404 errors when interacting with GitLab repositories. It refines how project identifiers are URL-encoded to correctly handle deeply nested group structures and corrects a malformed URL used for fetching raw file content. The overall impact is enhanced reliability and broader compatibility for accessing files and repositories within GitLab.

Highlights

  • URL Encoding Fix for Nested Groups: The method for URL-encoding project identifiers has been updated. Previously, urllib.parse.quote would over-encode slashes, leading to 404 errors on older GitLab instances when dealing with deeply nested groups (more than two levels). The change now specifically replaces slashes with %2F to maintain the correct structure expected by GitLab.
  • Raw File URL Correction: A missing slash in the raw file URL template has been added. This omission previously caused 404 errors when attempting to fetch the content of single files, as the URL was malformed.
  • Improved Compatibility: These fixes ensure that repositories with nested groups can now be traversed and single files downloaded without encountering 404 errors, improving compatibility with various GitLab setups, especially older instances.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the bug Something isn't working label Jan 20, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses two separate 404 errors when interacting with the GitLab API. The first fix correctly adds a missing slash to the raw file URL, resolving an issue when fetching file content. The second fix changes the URL encoding method for repository identifiers to support nested groups. While this may solve an issue with older GitLab instances as described, the new method is less robust as it only encodes slashes and will fail for repository paths containing other special characters like spaces. I've left a comment with a suggestion to revert to the more standard and safer URL encoding function to prevent future issues.

revert: restore standard URL encoding for repository identifier

Revert the incorrect change from urllib.parse.quote to str.replace.
The standard quote function correctly handles all special characters
and is not the root cause of the 404 issue.

The actual fixes needed are:
- Pass project_id instead of project string to fetch_files
- Add missing slash in raw file URL path

Keep urllib.parse.quote(identifier, safe=\"\") as the robust encoding method.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant