-
Notifications
You must be signed in to change notification settings - Fork 701
fix(aihubmix_image): fix reference image form type from llm to form #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xinrui-z, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration inconsistency in several image processing tools by standardizing the input form type for reference images. The change ensures that image inputs are correctly recognized as 'form' types rather than 'LLM' types, which is crucial for proper integration with Dify's workflow system. Additionally, the descriptions for these image parameters have been enhanced to better communicate their compatibility with workflow variables and node connections, improving user understanding and system interoperability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly changes the form type for image input parameters from llm to form across several tool definition files. This is a necessary fix to enable image inputs to be properly handled as form fields in the Dify UI, allowing for file uploads and connections from other workflow nodes. The changes are consistent and correct. I've added one comment on gpt-image-edit.yaml to suggest updating the parameter's description for consistency and clarity, similar to how it was done in doubao.yaml. Otherwise, the changes look good.
| ja_JP: "編集する画像(URL、base64データ、またはファイルパス)" | ||
| llm_description: "Input image to be edited using GPT Image Edit. Supports URL, base64 data, or file path" | ||
| form: llm | ||
| form: form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While changing the form type to form is correct, the descriptions for this image parameter should also be updated to reflect the new capabilities, ensuring consistency with other tools. The current human_description and llm_description don't mention support for workflow connections or Dify file variables, which this change enables. Please consider updating them for better user clarity, similar to the changes made in doubao.yaml and other files in this PR.
Related Issues or Context
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment