Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JWT Adapter #19 #20

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from
Open

JWT Adapter #19 #20

wants to merge 1 commit into from

Conversation

fgsl
Copy link

@fgsl fgsl commented Jul 14, 2021 •
edited
Loading

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC yes
QA no

Description

  • This feature request adds something the library currently does not support: JWT authentication.
    • This should be added because JWT is a pattern specification (RFC 7519) and microservice based applications can be use it
    • Applications with JWT authentication as requirement will enable it
    • This code be used in microservice applications or sessionless applications.
    • TARGET THE develop BRANCH

froschdesign
froschdesign reviewed Jul 15, 2021
View reviewed changes
src/Jwt.php
*/
namespace Laminas\Authentication;

class Jwt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this class is needed? The authentication adapter itself uses only the getPayload method.
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign left review comments

Assignees
No one assigned
Labels
Awaiting Author Updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgsl @froschdesign