Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and fix num-prime trait error. #1872

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/iai_main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
pip install -r requirements.txt
sudo apt update
sudo apt install -y valgrind
cargo install --version 0.3.1 iai-callgrind-runner
cargo install --version 0.14.0 iai-callgrind-runner

- name: Run iai benchmarks
run: make iai-benchmark-action
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/iai_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
pip install -r requirements.txt
sudo apt update
sudo apt install -y valgrind
cargo install --version 0.3.1 iai-callgrind-runner
cargo install --version 0.14.0 iai-callgrind-runner

- name: Run iai benchmarks
if: ${{ steps.cache-iai-results.outputs.cache-hit != 'true' }}
Expand All @@ -63,7 +63,7 @@ jobs:
pip install -r requirements.txt
sudo apt update
sudo apt install -y valgrind
cargo install --version 0.3.1 iai-callgrind-runner
cargo install --version 0.14.0 iai-callgrind-runner

- name: Restore cache for ${{ github.event.pull_request.base.sha }}
uses: actions/cache/restore@v3
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
## Cairo-VM Changelog

#### Upcoming Changes

* fix: [#1872](https://github.com/lambdaclass/cairo-vm/pull/1872)
* Fix a trait error with the num-primes crate and update dependencies.

* fix: [#1868](https://github.com/lambdaclass/cairo-vm/pull/1855):
* Adds logic to include the 3 new builtins in `builtin_segments` when serializing the output cairo pie's metadata.

Expand Down
Loading
Loading