Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #1680

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Update CODEOWNERS #1680

merged 2 commits into from
Mar 20, 2024

Conversation

pefontana
Copy link
Collaborator

@pefontana pefontana commented Mar 19, 2024

Update CODEOWNERS

Kill Marian

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (ef9ef5b) to head (e4eac95).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1680   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files          95       95           
  Lines       38151    38151           
=======================================
  Hits        36894    36894           
  Misses       1257     1257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 19, 2024

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.261 ± 0.030 2.228 2.324 1.00
head big_factorial 2.262 ± 0.018 2.242 2.293 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.256 ± 0.014 2.235 2.274 1.00
head big_fibonacci 2.271 ± 0.031 2.213 2.336 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.381 ± 0.124 8.251 8.530 1.00
head blake2s_integration_benchmark 8.429 ± 0.148 8.276 8.627 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.334 ± 0.028 2.308 2.411 1.00 ± 0.01
head compare_arrays_200000 2.326 ± 0.013 2.304 2.346 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.461 ± 0.008 1.453 1.477 1.01 ± 0.01
head dict_integration_benchmark 1.449 ± 0.010 1.434 1.466 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.321 ± 0.019 1.301 1.370 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 1.303 ± 0.007 1.290 1.312 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.423 ± 0.134 8.250 8.604 1.00 ± 0.02
head integration_builtins 8.405 ± 0.140 8.264 8.624 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.810 ± 0.424 8.494 9.633 1.01 ± 0.05
head keccak_integration_benchmark 8.720 ± 0.159 8.514 8.894 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.357 ± 0.030 2.322 2.417 1.00 ± 0.01
head linear_search 2.351 ± 0.018 2.336 2.393 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.586 ± 0.010 1.566 1.598 1.00
head math_cmp_and_pow_integration_benchmark 1.605 ± 0.023 1.575 1.651 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.443 ± 0.010 1.435 1.466 1.00
head math_integration_benchmark 1.443 ± 0.023 1.419 1.501 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.271 ± 0.012 1.257 1.292 1.00
head memory_integration_benchmark 1.284 ± 0.016 1.256 1.306 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.625 ± 0.016 1.607 1.664 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.624 ± 0.013 1.608 1.655 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 599.9 ± 17.0 589.4 646.8 1.01 ± 0.03
head pedersen 592.4 ± 2.4 588.2 596.8 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.008 ± 0.011 0.990 1.025 1.01 ± 0.01
head poseidon_integration_benchmark 0.997 ± 0.007 0.982 1.006 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.864 ± 0.011 1.852 1.886 1.00
head secp_integration_benchmark 1.876 ± 0.032 1.858 1.965 1.01 ± 0.02
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 725.5 ± 4.1 721.3 736.1 1.00
head set_integration_benchmark 728.5 ± 4.4 724.0 738.2 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.690 ± 0.105 4.570 4.945 1.01 ± 0.02
head uint256_integration_benchmark 4.663 ± 0.039 4.602 4.701 1.00

@pefontana pefontana marked this pull request as ready for review March 20, 2024 15:24
@pefontana pefontana added the pipelines This PR/issue is exclusively about improving our CI label Mar 20, 2024
Copy link
Contributor

@fmoletta fmoletta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

@pefontana pefontana added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 16a844e Mar 20, 2024
53 of 54 checks passed
@pefontana pefontana deleted the update-codeowners branch March 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants